search

terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
825 stars 533 forks source link

feat: support optional tag binding #885

Closed bharathkkb closed 5 months ago

bharathkkb commented 6 months ago

fixes #884

bharathkkb commented 6 months ago

My comments center around the lack of usage of google_tags_tag_key in the module? AFAIK, the key and the value are paired together for the binding and we should give the user the ability to create both. What do you think?

My reasoning for this was the common use case seems to be that keys (and values) are defined at a higher level (org/folder) and only binding is performed at the project during creation time. There could be usecases where maybe project scoped tags are created but I am thinking we should recommend use the tags module for that.

This would be similar to how we only allow attaching to a shared VPC via PF while requiring network module for full create functionality.