terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
825 stars 533 forks source link

Allow soft_delete_policy configuration for bucket #896

Closed PatriceGehinKiabi closed 2 months ago

PatriceGehinKiabi commented 4 months ago

TL;DR

Allow soft_delete_policy configuration for bucket.

Terraform Resources

Soft delete is a recent feature on buckets and is activated by default with a default 7 days hold.

Bucket module has been updated to allow its configuration (see https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/storage_bucket#soft_delete_policy), but the google project factory module and submodules do not allow us to configure it. It would be great to be allowed to set the value we want, as we can already set versioning and so on.

Detailed design

No response

Additional information

No response

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days