terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
825 stars 533 forks source link

enable_shared_vpc_service_project is not working #920

Closed red8888 closed 1 week ago

red8888 commented 2 months ago

TL;DR

This config does not create an attachment:

module "shared_vpc_attachment" {
  source                             = "terraform-google-modules/project-factory/google//modules/shared_vpc_access"
  enable_shared_vpc_service_project  = true
  host_project_id                    = "sdfsd"
  service_project_id                 = "sdfsdf"
  active_apis = [
    "vpcaccess.googleapis.com",
  ]
  shared_vpc_subnets = [
    "sdfsdf",
    "sdfsdfsd",
  ]
}

Expected behavior

It should create a google_compute_shared_vpc_service_project resource but its only assigning perms

Observed behavior

it does not it only creates these to perms

  + resource "google_compute_subnetwork_iam_member" "service_shared_vpc_subnet_users" {
  + resource "google_compute_subnetwork_iam_member" "service_shared_vpc_subnet_users" {

Terraform Configuration

see above for snippet

Terraform Version

Terraform v1.1.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v5.32.0
+ provider registry.terraform.io/hashicorp/google-beta v5.32.0
+ provider registry.terraform.io/hashicorp/random v3.6.2
+ provider registry.terraform.io/hashicorp/time v0.11.2

Additional information

No response

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days