terraform-google-modules / terraform-google-pubsub

Creates Pub/Sub topic and subscriptions associated with the topic
https://registry.terraform.io/modules/terraform-google-modules/pubsub/google
Apache License 2.0
89 stars 126 forks source link

Add types for subscriptions config #172

Closed nguyen-vo closed 6 months ago

nguyen-vo commented 10 months ago

TL;DR

Add type to the subscription configs. This helps improve developer experience and ease to use

Terraform Resources

terraform-google-modules/terraform-google-pubsub

Additional information

We have different subscription configs, but currently, they have any type that is hard for new developers to use the module. I had to spend sometimes jump back and forth between the PubSub resource page on the GCP provider Terraform page and GitHub to figure out how to set up BigQuery subscription with other attributes like ack_deadline_seconds, dead_letter_policy, etc..

The BigQuery module has a great table for the input https://github.com/terraform-google-modules/terraform-google-bigquery/blob/master/README.md

Greatly appreciate if we could add something like it

No response

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days