search

terraform-google-modules / terraform-google-scheduled-function

Sets up a scheduled job to trigger events and run functions
https://registry.terraform.io/modules/terraform-google-modules/scheduled-function/google
Apache License 2.0
71 stars 48 forks source link

feat: Add files_to_exclude_in_source_dir variable to exclude unwanted… #259

Closed davidg251 closed 2 weeks ago

davidg251 commented 1 month ago

… files/folder in the function package.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

davidg251 commented 1 month ago

Hi guys,

I am using this module to create a scheduler to trigger a cloud function written in python. As part of the local development process the __pycache__ and venv folders are created, and the creation of the zip file was failing with 

error creating archive: error archiving directory: lstat /usr/local/bin/python: no such file or directory

Normally, one wants to keep the folders metioned above to test the new changes on the function. That's the reason why I created this PR, just adding the variable files_to_exclude_in_source_dir to pass to the module terraform-google-modules/event-function/google used to create the function.

Cheers!

apeabody commented 1 month ago

/gcbrun

apeabody commented 2 weeks ago

/gcbrun