search

terraform-google-modules / terraform-google-slo

Creates SLOs on Google Cloud from custom Stackdriver metrics capability to export SLOs to Google Cloud services and other systems
https://registry.terraform.io/modules/terraform-google-modules/slo/google
Apache License 2.0
63 stars 28 forks source link

fix: Ignore "run.googleapis.com/operation-id" annotation in Cloud Run #114

Closed skoenig closed 1 year ago

skoenig commented 1 year ago

As mentioned in the docs, the Cloud Run API can add additional annotations that were not provided in the Terraform configuration. The "run.googleapis.com/operation-id" annotation causes unnecessary changes, so this PR adds the lifecycle.ignore_changes rule to the metadata.0.annotations field.

Tests with make docker_test_integration ran successful.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

comment-bot-dev commented 1 year ago

Thanks for the PR! 🚀
✅ Lint checks have passed.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days