search

terraform-google-modules / terraform-google-slo

Creates SLOs on Google Cloud from custom Stackdriver metrics capability to export SLOs to Google Cloud services and other systems
https://registry.terraform.io/modules/terraform-google-modules/slo/google
Apache License 2.0
63 stars 29 forks source link

BUGFIX - Bad value on default_table_expiration_ms (6 days and not 1 year) #15

Closed bkamin29 closed 4 years ago

bkamin29 commented 4 years ago

Hello,

on the module slo-pipeline in main.tf we can find an error in the TF resource google_bigquery_dataset.main on the attribute default_table_expiration_ms. The static value choose is bad because 525600000ms is equal to 6 days only and not 365 days / 1 year ..

I have added a new variable dataset_default_table_expiration_ms with a default to never. Expiration table on a Dataset is not a sliding windows, so after 1 year all datas will be deleted, not only the datas older than one year..

Benjamin

image

ocervell commented 4 years ago

Thank you for this PR @benesis002. LGTM, merging.

clement-pruvot commented 4 years ago

Hi, with the default value "", I have the error : "Error: Incorrect attribute value type

on .terraform/modules/slo-pipeline/modules/slo-pipeline/main.tf line 55, in resource "google_bigquery_dataset" "main": 55: default_table_expiration_ms = var.dataset_default_table_expiration_ms |---------------- | var.dataset_default_table_expiration_ms is ""

Inappropriate value for attribute "default_table_expiration_ms": a number is required." Was it working for you ? did something changed then ? I am forced to set a value :'( 👎