terraform-google-modules / terraform-google-slo

Creates SLOs on Google Cloud from custom Stackdriver metrics capability to export SLOs to Google Cloud services and other systems
https://registry.terraform.io/modules/terraform-google-modules/slo/google
Apache License 2.0
63 stars 29 forks source link

add ability to disable logs-writer iam #80

Closed Naterd closed 3 years ago

Naterd commented 3 years ago

Currently, when using foreach to create our SLOs. We elected to disable the modules granting of IAM roles to prevent it from doing the same action over and over with the same custom service account.

The logs writer role is not able to be prevented causing duplicate resources to be made.



module.slo-istio["*-prod-us-2-useas1-gke-main-cluster-domain*-prod-us-2-useas1-avail"].google_project_iam_member.logs-writer: Still creating... [10s elapsed]

module.slo-istio["*-prod-us-2-useas1-gke-main-cluster-ai-a*-prod-us-2-useas1-avail"].google_project_iam_member.logs-writer: Still creating... [10s elapsed]

module.slo-istio["*-prod-us-1-useas1-gke-main-cluster-voic*-prod-us-1-useas1-avail"].google_project_iam_member.logs-writer: Still creating... [20s elapsed]```
ocervell commented 3 years ago

LGTM, merging !