Tweaks to slo-generator examples

gplasky commented 3 years ago

Templatize BQ and GCS locations
Update provider spec to match TF >0.13 while maintaining 0.12 compat
Update docs to match spec using make generate_docs

gplasky commented 3 years ago

There's an issue with the development tool chain: the Makefile uses an unbounded version number for the CFT developer tools Docker image:

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0

compared to the version specified in the Cloudbuild pipeline file(s):

_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '0.8.0'

cft/developer-tools 0.8.0, among other things (like the GCP SDK version), points to Terraform 0.12.20 vs whatever is in HEAD (currently 0.15.0). This caused the documentation checks, while valid on my local run (0.15.0) to fail in CI. Same applies to the version pinning of 0.12.26. I'm going to revert the version pin in the code and explicitly specify 0.8.0 in the Cloudbuild devtools image.

This should be a very temporary fix as I know @ocervell is working on a separate PR for upgrading to TF 0.13+.

ocervell commented 3 years ago

LGTM

terraform-google-modules / terraform-google-slo

Tweaks to slo-generator examples #86