terraform-google-modules / terraform-google-slo

Creates SLOs on Google Cloud from custom Stackdriver metrics capability to export SLOs to Google Cloud services and other systems
https://registry.terraform.io/modules/terraform-google-modules/slo/google
Apache License 2.0
63 stars 29 forks source link

Feature/7 re use new scheduled function #9

Closed taylorludwig closed 4 years ago

taylorludwig commented 4 years ago

Depends on https://github.com/terraform-google-modules/terraform-google-event-function/pull/38 and https://github.com/terraform-google-modules/terraform-google-scheduled-function/pull/28

Being merged and released first. Then we can update module source codes to move off of my forks.

taylorludwig commented 4 years ago

We could possibly add some better tests to verify the functions work as intended.

But after applying locally I have verified both the scheduled and event driven functions are being triggered. And I do see data showing up in bigquery for the slo-pipeline

ocervell commented 4 years ago

LGTM