Closed taylorludwig closed 4 years ago
We could possibly add some better tests to verify the functions work as intended.
But after applying locally I have verified both the scheduled and event driven functions are being triggered. And I do see data showing up in bigquery for the slo-pipeline
LGTM
Depends on https://github.com/terraform-google-modules/terraform-google-event-function/pull/38 and https://github.com/terraform-google-modules/terraform-google-scheduled-function/pull/28
Being merged and released first. Then we can update module source codes to move off of my forks.Updates the
slo
module to use thescheduled-function
module now that it has proper support for waiting forlocal_file
creations before creating the archive for the cloud functionUpdates
slo-pipeline
to useevent-function
module instead of duplicated functionality. Also relies on newlocal_file
toarchive
dependency functionalityUpdates the setup and tests to pass