search

terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
265 stars 425 forks source link

fix: mark replicas_instance_server_ca_certs output as sensitive #579

Closed aghassabian closed 9 months ago

aghassabian commented 9 months ago

It should fix error for server ca cert coming from this change on google provider 5.12 and later: https://github.com/hashicorp/terraform-provider-google/pull/16932

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

aghassabian commented 9 months ago

/gcbrun

imrannayer commented 9 months ago

/gcbrun

aghassabian commented 9 months ago

@imrannayer same issue for Postgressql module. Do you prefer to update this pull request or open a new one?

imrannayer commented 9 months ago

@aghassabian go ahead and add it in this PR

aghassabian commented 9 months ago

@aghassabian go ahead and add it in this PR

@imrannayer Done. Seems your action is required.

imrannayer commented 9 months ago

/gcbrun

aghassabian commented 9 months ago

@imrannayer Any update on this one? It's a blocker for me.