terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
263 stars 422 forks source link

fix: mssql - make instance_server_ca_cert output sensitive #609

Closed VladStarr closed 3 months ago

VladStarr commented 3 months ago

Changed the mssql module output instance_server_ca_cert to be marked as sensitive. This change should fix the following error:

│ Error: Output refers to sensitive values
│ 
│   on outputs.tf line 48:
│   48: output "instance_server_ca_cert" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

imrannayer commented 3 months ago

/gcbrun