search

terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
265 stars 427 forks source link

feat: adding support for automatic creation of psc consumer #613

Closed sid-occrp closed 1 week ago

sid-occrp commented 3 months ago

When using psc you can optionally create psc consumer for main and read replica in the specified network and subnet.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sid-occrp commented 3 months ago

@imrannayer @isaurabhuttam how is my PR looking ?

imrannayer commented 3 months ago

/gcbrun

imrannayer commented 3 months ago

/gcbrun

imrannayer commented 3 months ago

@sid-occrp integration test failed

Error: "name" ("your_network_name") doesn't match regexp "^(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)$"

  with module.network-auto-psc.module.vpc.google_compute_network.network,
  on .terraform/modules/network-auto-psc/modules/vpc/main.tf line 21, in resource "google_compute_network" "network":
  21:   name                                      = var.network_name
}
github-actions[bot] commented 2 weeks ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days