search

terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
263 stars 422 forks source link

fix!: Cleanup of old instance backups. Change role roles/cloudsql.editor to roles/cloudsql.admin #618

Closed tjespers closed 1 month ago

tjespers commented 1 month ago

This commit reverts the change to using the cloudsql.editor role for the backup service account from the cloudsql.admin role. This was introduced in https://github.com/terraform-google-modules/terraform-google-sql-db/pull/597 but due to this the deletion of old backups on the instance now receives a 403 error in the workflow. This is due to the fact that the cloudsql.editor role lacks the cloudsql.backupRuns.delete permission.

Closes: https://github.com/terraform-google-modules/terraform-google-sql-db/issues/617

imrannayer commented 1 month ago

/gcbrun

imrannayer commented 1 month ago

/gcbrun