terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
265 stars 427 forks source link

bug: fix invalid index with additional database and default database disabled #625

Closed q2w closed 2 months ago

q2w commented 2 months ago

This PR addresses https://github.com/terraform-google-modules/terraform-google-sql-db/issues/624.

Creation of addition_databases without default database doesn't create an issue of invalid index.

module "postgresql" {
  source  = "../terraform-google-sql-db/modules/postgresql"

  project_id = "<PROJECT_ID>"
  name = "database-instance"
  database_version = "POSTGRES_14"
  enable_default_db = false

  additional_databases = [{ name = "any_db_1", charset = "UTF8", collation = "en_US.UTF8" }]
}

Note: The PR also disables defaultVerify for postgresql test as it is flaky. No changes in this PR has any impact on the test.

q2w commented 2 months ago

/gcbrun

q2w commented 2 months ago

/gcbrun

imrannayer commented 2 months ago

/gcbrun

q2w commented 2 months ago

/gcbrun