terraform-google-modules / terraform-google-sql-db

Creates a Cloud SQL database instance
https://registry.terraform.io/modules/terraform-google-modules/sql-db/google
Apache License 2.0
263 stars 422 forks source link

fix: mysql module read_replica add missing ssl_mode in ip_configuration #628

Closed strimpak closed 4 weeks ago

strimpak commented 1 month ago

While using this module and mysql submodule, I noticed when I added ssl_mode for both my primary and replicas instances, in plan it was only changing primary. Could you please consider review this fix and merge it?

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

strimpak commented 1 month ago

@imrannayer , @isaurabhuttam could you please review this one?

imrannayer commented 4 weeks ago

/gcbrun