search

terraform-google-modules / terraform-google-startup-scripts

Provides a library of useful startup scripts to embed in VMs
https://registry.terraform.io/modules/terraform-google-modules/startup-scripts/google
Apache License 2.0
73 stars 36 forks source link

Spec test coverage #4

Closed jeffmccune closed 5 years ago

adrienthebo commented 5 years ago

@jeffmccune is this ready for a preliminary review or would you like to keep working on it a bit more?

jeffmccune commented 5 years ago

@jeffmccune is this ready for a preliminary review or would you like to keep working on it a bit more?

@adrienthebo Yes, this is ready now. I rebased it onto the current master and bumped the version of the docker image to 0.5.0 since it changed slightly by using a more recently maintained version of bats-assert.

Here's how I run it:

make docker_build_bats # to get 0.5.0
make docker_bats_parallel

Parallel is 30 to 50% faster than make docker_bats, but only a few seconds in practice.

jeffmccune commented 5 years ago

This should be ready for merge now. I added Adrien's feedback and rebased in 5322b00...23e6041