search

terraform-google-modules / terraform-google-vault

Deploys Vault on Compute Engine
https://registry.terraform.io/modules/terraform-google-modules/vault/google
Apache License 2.0
192 stars 127 forks source link

compute router bgp keepalive_interval is not set #171

Closed dlouvier closed 1 year ago

dlouvier commented 1 year ago

TL;DR

As shown in the screenshot from the plan, keepalive_interval is not set and this value needs to be between 20 and 60. This causes every time plans runs and apply, the provider tries to replace this value causing necessary noise in the plan.

image

Expected behavior

Set this value to it's default, 20, so plan doesn't show this again.

Observed behavior

No response

Terraform Configuration

n/a

Terraform Version

❯ terraform version
Terraform v1.3.7

Other older versions also have the problem. This was introduced here: https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#4130-march-7-2022 so you need to use google providers > v4.13



### Additional information

_No response_
dlouvier commented 1 year ago

The following PR fix the issue: https://github.com/terraform-google-modules/terraform-google-vault/pull/169

dlouvier commented 1 year ago

Hi @apeabody , any chance you could help here?