terraform-google-modules / terraform-google-vm

Provisions VMs in Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/vm/google
Apache License 2.0
220 stars 367 forks source link

feat: support setting nic_type of primary network interface #334

Closed tpdownes closed 1 year ago

tpdownes commented 1 year ago

This PR adds support to specify the NIC type of the primary network interface for instance templates. This field is important VM families and operating systems that support GVNIC and get increased network performance. It defaults to null, the current behavior (unspecified), so this is not a change that requires user action. var.additional_networks supports this field, but the primary interface does not.

I can eventually see a breaking change where var.additional_networks becomes var.networks (or var.network_interfaces) and the primary network interface is inferred from the 1st element in the list. This would eliminate functionality gaps between the primary interface and secondary interfaces.