search

terraform-google-modules / terraform-google-vm

Provisions VMs in Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/vm/google
Apache License 2.0
220 stars 368 forks source link

feat(TF>=1.3)!: make mig health check fields optional #385

Closed rauny-brandao closed 4 months ago

rauny-brandao commented 6 months ago

This makes MIG health check fields optional, the default values comes from the variable health_check, closes #153

g-awmalik commented 6 months ago

/gcbrun

g-awmalik commented 6 months ago

@rauny-brandao - I just realized that you haven't added any assertions for the healthcheck example that you modified. Can you please take a moment and add them here?

rauny-brandao commented 5 months ago

is there something missing for this to be merged @apeabody & @g-awmalik?!

thanks!