Closed arthurlapertosa closed 1 month ago
/gcbrun
@apeabody Could you PTAL ?
/gcbrun
FYI @arthurlapertosa
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/instance_template/README.md /tmp/tmp.4PKCCzT0D4/generate_docs/workspace/modules/instance_template/README.md
23c23
< | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `""` | no |
---
> | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `null` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
FYI @arthurlapertosa
Checking for documentation generation diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/instance_template/README.md /tmp/tmp.4PKCCzT0D4/generate_docs/workspace/modules/instance_template/README.md 23c23 < | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `""` | no | --- > | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `null` | no | Error: Documentation generation has not been run, please run the 'make docker_generate_docs' command and commit the above changes.
Sorry, I forgot to update the documentation after changing the default value to null
. Just did it.
/gcbrun
@apeabody could you please trigger the workflows?
/gcbrun
Thanks @arthurlapertosa! - Can you resolve the appropriate open comments?
@erlanderlo could you please take a look at the open comments?
@apeabody all open comments addressed. Please take another look!
/gcbrun
add confidential_instance_type to instance_template module, with example and tests