search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
61 stars 70 forks source link

Update int test to receive access context manager policy rather than create + destroy #103

Open bharathkkb opened 1 year ago

bharathkkb commented 1 year ago

TL;DR

We do a few clean ups between tests like https://github.com/terraform-google-modules/terraform-google-vpc-service-controls/blob/0d94f375b9e4aa98d830b02e53b34cc83c79075b/build/int.cloudbuild.yaml#L26that can result in the access context manager policy not existing. It would be better to skip testing the main root module as it is a single resource without any logic and instead receive a static policy as a var for testing other more complex submodules.

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

N/A

Terraform Version

N/A

Additional information

No response

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

apeabody commented 8 months ago

Looks like this is also breaking the terraform-example-foundation test