search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

Removed google_access_context_manager_service_perimeter_resource terr… #109

Closed gwiazdp closed 1 year ago

gwiazdp commented 1 year ago

Removed google_access_context_manager_service_perimeter_resource terraform resource and move resource list directly into google_access_context_manager_service_perimeter. In dry run mode module works but in standard mode doesn't work. There is an error "Error creating ServicePerimeter: googleapi: Error 400: Invalid Directional Policies set in Perimeter 'accessPolicies//servicePerimeters/xxx': Error in IngressTo: 'projects/' is defined in IngressTo.resources, but it is not present in ServicePerimeterConfig.resources. Only resources protected by this Service Perimeter can be put in IngressTo.resources." This is caused because ingress rule needs resources list (for example project number) during creation regular service perimeter. I've moved list and deleted reference to google_access_context_manager_service_perimeter_resource in output file.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.