search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

feat: add Terraform script for setting up a VPC-SC denials dashboard #152

Closed melissa-mo closed 2 weeks ago

melissa-mo commented 4 weeks ago

This directory was created by the VPC-SC team to provide customers with a quick, easy way to set up the configurations for a VPC-SC denials dashboard that will allow customers to analyze their policies to see if they’re working as intended. It provides a logging module that sets up the Cloud Logging configuration and optional dashboard and alerting modules to set up a Cloud Monitoring dashboard and alert policy examples.

imrannayer commented 4 weeks ago

@melissa-mo thx for the PR. Usually we create examples as self contained and hard coded values (except parameters like project ID etc).

melissa-mo commented 4 weeks ago

@melissa-mo thx for the PR. Usually we create examples as self contained and hard coded values (except parameters like project ID etc).

I see, thanks for letting me know. We'd prefer to keep these files as-is, so is there another place we can put this code instead of the examples folder?

bharathkkb commented 3 weeks ago

@melissa-mo Ideally this could be refactored into a module and kept within https://github.com/terraform-google-modules/terraform-google-vpc-service-controls/tree/master/modules. This will follow our conventions and allow users to directly use this as a module via TF registry.

If that is not possible I think maybe https://github.com/GoogleCloudPlatform/professional-services/tree/main/examples would be a better spot which has similar examples

melissa-mo commented 2 weeks ago

Thank you for your feedback. After some discussion, we've decided not to publish our Terraform script to GitHub for now. Closing this request.