search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

used dynamic block to handle lack of device policy #31

Closed rajcheval closed 4 years ago

rajcheval commented 4 years ago

I am trying to fix this issue

https://github.com/terraform-google-modules/terraform-google-vpc-service-controls/issues/26

This issue prevents me from creating access_level if I am not creating a device policy.

rajcheval commented 4 years ago

One of the checks failed. However, I am unable to view the reason for failure. when I press "Details" it asks me to log into GCP. I do log into my own GCP and I get this error:

There was an error while loading /cloud-build/builds/8242826b-f5eb-4b3e-aa6c-113348253201?project=2843445864.

You are missing at least one of the following required permissions: Project

cloudbuild.builds.get

bharathkkb commented 4 years ago

@rajcheval thanks for the contribution. There was a problem with the CI setup on our end that was fixed in #32. Could you rebase and try again?

bharathkkb commented 4 years ago

LGTM

rajcheval commented 4 years ago

Is there any ETA on when this pull request will be reviewed?

rajcheval commented 4 years ago

I am not sure why the tests were failing yesterday and now they have passed. I am hoping that we will get this merged after review. Thanks

morgante commented 4 years ago

Looks like it was a temporary failure due to quota. Thank you for the contribution and patience!