search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

outputs in submodules are limited and possibly incorrect #49

Closed michaeldeman closed 3 years ago

michaeldeman commented 3 years ago

I am using _terraform-google-vpc-service-controls/modules/regular_serviceperimeter to create a regular perimeter for a project. I wanted to add the perimeter name as an output from the module and am unable to do so.

Looking at the code it appears that the output.tf for regular_service_perimeter only includes _value = var.sharedresources which is actually a parameter that should only be supplied for a bridge perimeter anyway? I am on 3.0.x and it looks similar for 2.1.x.

morgante commented 3 years ago

Sure, feel free to add an output. We will review a PR.