github-issue-49; add a couple of outputs to regular vpc module

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments

https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google

Apache License 2.0

59 stars 67 forks source link

github-issue-49; add a couple of outputs to regular vpc module #50

Closed michaeldeman closed 3 years ago

michaeldeman commented 3 years ago

Some dithering about output names and perimeter 'id' vs. 'name'. Meanwhile, this works for me in two different environments. Please advise.

comment-bot-dev commented 3 years ago

Thanks for the PR! 🚀 Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠️check_whitespace Failed whitespace check. More details below.

Checking for trailing whitespace
Checking for missing newline at end of file
Error: No newline at end of file ./modules/regular_service_perimeter/outputs.tf

michaeldeman commented 3 years ago

pulling back. I never ran the test integration suite locally before PR and should have suspected by the very fact that the code supplies outputs for bridge VPC in regular VPC module that there were other things haywire.

michaeldeman commented 3 years ago

appears test-suite, beyond actual modules, does not distinguish between bridge & regular VPC for at least some nominal use cases.