Closed aweberlopes closed 2 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for the PR! 🚀
✅ Lint checks have passed.
@googlebot I signed it!
@morgante Can you provide me the info where the Cloud Build Job fails that i can fix the issue I can not test it localy in my env because i can not delete access policy it would delete all existing perimeter.
Hello together is here happening something?
Hi this is is the test failure:
module.example.module.access_context_manager_policy.google_access_context_manager_access_policy.access_policy: Destroying... [id=580200975946]
module.example.module.access_context_manager_policy.google_access_context_manager_access_policy.access_policy: Destruction complete after 1s
Error: cannot destroy instance without setting deletion_protection=false and running `terraform apply`
So tests are successful. Can somebody have a look on it?
@morgante Is something missing here?
will fix the rest tomorrow @morgante thanks for the sugesstions and fixes
@morgante so simplified it can you check again?
Okay will have a look thanks.
this looks useful. I'll definitely try it out once released.
i've been testing this branch with success on a project of mine
Hello Guys,
i added my code and checked the Contributing Guidelines.
I tested the VPC SC in a Demo Organization and mostly functions work similar like on the ressource.
Please be kindly its my first pull request on GitHub so maybe i missing something.