terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

Added Ingress and Egress Rules for Standard and Dry Run #55

Closed aweberlopes closed 2 years ago

aweberlopes commented 2 years ago

Hello Guys,

i added my code and checked the Contributing Guidelines.

I tested the VPC SC in a Demo Organization and mostly functions work similar like on the ressource.

Please be kindly its my first pull request on GitHub so maybe i missing something.

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

comment-bot-dev commented 2 years ago

Thanks for the PR! 🚀
✅ Lint checks have passed.

aweberlopes commented 2 years ago

@googlebot I signed it!

aweberlopes commented 2 years ago

@morgante Can you provide me the info where the Cloud Build Job fails that i can fix the issue I can not test it localy in my env because i can not delete access policy it would delete all existing perimeter.

aweberlopes commented 2 years ago

Hello together is here happening something?

morgante commented 2 years ago

Hi this is is the test failure:

       module.example.module.access_context_manager_policy.google_access_context_manager_access_policy.access_policy: Destroying... [id=580200975946]
       module.example.module.access_context_manager_policy.google_access_context_manager_access_policy.access_policy: Destruction complete after 1s

       Error: cannot destroy instance without setting deletion_protection=false and running `terraform apply`
aweberlopes commented 2 years ago

So tests are successful. Can somebody have a look on it?

aweberlopes commented 2 years ago

@morgante Is something missing here?

aweberlopes commented 2 years ago

will fix the rest tomorrow @morgante thanks for the sugesstions and fixes

aweberlopes commented 2 years ago

@morgante so simplified it can you check again?

aweberlopes commented 2 years ago

Okay will have a look thanks.

bchazalet commented 2 years ago

this looks useful. I'll definitely try it out once released.

bchazalet commented 2 years ago

i've been testing this branch with success on a project of mine