search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

Ignore Changes on Resources #61

Closed aweberlopes closed 2 years ago

aweberlopes commented 2 years ago

https://github.com/terraform-google-modules/terraform-google-vpc-service-controls/issues/60

this is the code for this issue

comment-bot-dev commented 2 years ago

Thanks for the PR! 🚀
✅ Lint checks have passed.

aweberlopes commented 2 years ago

@morgante Nice idea i will rewrite my stuff to it.

aweberlopes commented 2 years ago

@morgante the problem on that implementation will still be that the modules could not help on manual changes. Means if somebody wants more of a strict mode that deletes everything what is not done by code.

For the solution it self I tested it works as expected. the needed resources will be added with a dedicated resource in but i have still to use lifecycle { ignore_changes = [status[0].resources] }

aweberlopes commented 2 years ago

@morgante Can you check this if you get time. Many thanks :)