terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
59 stars 67 forks source link

Linters don't work in docker (master branch) #7

Closed ivankorn closed 4 years ago

ivankorn commented 4 years ago
$ make docker_run
docker run --rm -it \
    -e PROJECT_ID \
    -e BUCKET_NAME \
    -e SERVICE_ACCOUNT_JSON \
    -e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=/cft/workdir/credentials.json \
    -e GOOGLE_APPLICATION_CREDENTIALS=/cft/workdir/credentials.json \
    -v /home/data/workspace/google/terraform-google-vpc-service-controls:/cft/workdir \
    gcr.io/cloud-foundation-cicd/cft/kitchen-terraform:1.0.1 \
    /bin/bash -c "source test/ci_integration.sh && setup_environment && exec /bin/bash"
Activated service account credentials for: [project-factory-9942@gl-ivankorniienko-seed.iam.gserviceaccount.com]
bash-4.4# make -s
Running shellcheck
xargs: shellcheck: No such file or directory
make: *** [Makefile:38: check_shell] Error 127
bash-4.4# 
Tfmenard commented 4 years ago

I don't think the linters are supposed to work with this image. There is another image that has the linters installed.

aaron-lane commented 4 years ago

Fixed by #15.