search

terraform-google-modules / terraform-google-vpc-service-controls

Handles opinionated VPC Service Controls and Access Context Manager configuration and deployments
https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google
Apache License 2.0
61 stars 70 forks source link

Fix dry-run egress ingress operations #83

Closed masterleros closed 2 years ago

masterleros commented 2 years ago

This change is to fix the dynamic operations on ingress and egress policies in dry-run mode, these are currently failing The change itself is just update "spec" to match "status" implementation that is properly working

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

comment-bot-dev commented 2 years ago

Thanks for the PR! 🚀
✅ Lint checks have passed.

masterleros commented 2 years ago

LGTM Could you please sign the CLA @masterleros

@bharathkkb CLA is already signed, I've submitted the changes and additional type fixes plus added additional documentation on the variables descriptions as it was not there.

Thank you Leo