Closed jeffreysbeckett closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thanks for the PR! π Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.
Running terraform fmt
Running terraform validate
terraform_validate .
Success!
The configuration is valid.
terraform_validate ./examples/automatic_folder
Success!
The configuration is valid.
terraform_validate ./examples/bq-exfil-demo
Success!
The configuration is valid.
terraform_validate ./examples/onprem_demo
Success!
The configuration is valid.
terraform_validate ./examples/onprem_demo/onprem_project
Success!
The configuration is valid.
terraform_validate ./examples/onprem_demo/vpc_sc_project
Success!
The configuration is valid.
terraform_validate ./examples/simple_example
Success!
The configuration is valid.
terraform_validate ./examples/simple_example_access_level
Success!
The configuration is valid.
terraform_validate ./examples/simple_example_access_level_dry_run
Success!
The configuration is valid.
terraform_validate ./examples/simple_example_bridge
Success!
The configuration is valid.
terraform_validate ./examples/simple_example_dynamic
β·
β
Error: Unsupported argument β
β
on ../../main.tf line 21, in resource "google_access_context_manager_access_policy" "access_policy": β
21:
scopes
= var.scopes
β
β
An argument named "scopes" is not expected here. β΅ terraform_validate ./examples/simple_example_policy_scopes Success! The configuration is valid. terraform_validate ./examples/simple_example_with_ingress_rule Success! The configuration is valid. terraform_validate ./modules/access_level Success! The configuration is valid. terraform_validate ./modules/bridge_service_perimeter Success! The configuration is valid. terraform_validate ./modules/regular_service_perimeter Success! The configuration is valid. terraform_validate ./test/fixtures/simple_example Success! The configuration is valid. terraform_validate ./test/fixtures/simple_example_bridge Success! The configuration is valid. terraform_validate ./test/setup Success! The configuration is valid.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days
My company is pretty big on VPCSC and we noticed that Access Policies gained a new option, Scopes. Scopes allow Access Policies to be set for Folders and Projects instead of just the organization. Along with this addition, organizations can now have multiple Access Policies per organization. For some of our more complex customers, this allows us to reduce the amount of orgs they need.
This is my first PR for the terraform-google-modules org and first PR for Open Source projects.
I have also included an example for this PR and this should resolve feature request #86 .