terraform-ibm-modules / dev-rag

A temporary repo for development of rag stack
Apache License 2.0
0 stars 2 forks source link

feat: existing scc instance for DA #8

Closed jor2 closed 2 months ago

jor2 commented 3 months ago

Description

Enable skipping SCC provisioning https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/issues/131

Release required?

Release notes content

enable skipping SCC provisioning by providing option for passing existing scc instance id.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 3 months ago

@jor2 can you create a PR in https://github.com/terraform-ibm-modules/stack-ibm-core-security-services with the same change. That repo has a test to test existing resources, so you can update the test to pass it so we test the use case in the stack. This repo does not yet have a test to test existing resource (tracked here), so at least we could use the other repo to test first.

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

jor2 commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

@jor2 FYI, we are no longer going to merge any PRs for the basic (code engine) variation in this repo. All new PRs will go directly into the original RAG repo once https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/pull/180 is merged.

FYI, I expect the pipeline to fail due to the SCC bug. The AI Security Guardrails 2.0 profile is also impacted