feat: added support to enable the secrets manager public cert engine

iamar7 commented 1 month ago

Description

https://github.com/terraform-ibm-modules/stack-ibm-core-security-services/issues/59

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 4 weeks ago

/run pipeline

iamar7 commented 3 weeks ago

/run pipeline

iamar7 commented 2 weeks ago

/run pipeline

iamar7 commented 2 weeks ago

/run pipeline

iamar7 commented 2 weeks ago

/run pipeline

SirSpidey commented 1 week ago

@iamar7 I approved, but I do have one suggestion.

iamar7 commented 1 week ago

/run pipeline

iamar7 commented 6 days ago

/run pipeline

ocofaigh commented 6 days ago

@iamar7 The tests are blocked in this repo due to https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5586 We can add a workaround however we are expecting a fix from the provider soon, so going to wait for that. This feature is not a high priority so it can wait until after the fix is in. We already document how consumers can workaround the issue: https://cloud.ibm.com/docs/security-services?topic=security-services-known-issues#ki-scc-attachments

terraform-ibm-modules / stack-ibm-core-security-services