feat: used en latest version_locator and used cos instance created by obs d…

terraform-ibm-modules / stack-ibm-core-security-services

Deploy core security and other supporting services to get set up to manage the security compliance of the resources in your account.

Apache License 2.0

1 stars 3 forks source link

feat: used en latest version_locator and used cos instance created by obs d… #31

Closed Soaib024 closed 4 months ago

Soaib024 commented 4 months ago

used EN latest version_locator and passed cos instance created by obs DA to EN

Description

https://github.com/terraform-ibm-modules/stack-ibm-core-security-services/issues/9

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

Changes:

Updated core-security-services-en version_locator to latest (v1.5).
Passed CRN of COS instance created by core-security-observability to core-security-services-en.
Skipped COS-KMS auth creation in core-security-services-en as that will be created by core-security-observability.
core-security-services-en is already using KMS created by core-security-services-kms, so no changes required.

Note: The names of the stack elements are: 1-core-security-services-kms 3-core-security-observability 2-core-security-services-en

Now, EN is dependent on observability, so should we change the name to 2-core-security-observability and 3-core-security-services-en to reflect the actual order of the stack? @ocofaigh @tyao117