search

terraform-ibm-modules / stack-ibm-core-security-services

Deploy core security and other supporting services to get set up to manage the security compliance of the resources in your account.
Apache License 2.0
1 stars 3 forks source link

[stack-ibm-core-security-services] Update member names #34

Closed ocofaigh closed 1 month ago

ocofaigh commented 1 month ago

Proposal:

joealewine commented 1 month ago
  1. should be "Key Protect".
SirSpidey commented 1 month ago

Logging and activity tracker are going to be replaced with IBM Cloud Logs, so I wonder if Activity Tracker should be left out of 2. In any case, it's Activity Tracker. Activity tracking wouldn't be capitalized. (2 - Logging, monitoring, activity tracking).

Key management is more than Key Protect, right? But it should be sentence case: 11 - Key management.

jor2 commented 1 month ago

@ocofaigh @SirSpidey should it not follow the same naming conventions as these https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/blob/f00047ce548cb8f3570c214aa50bd5c3a5f93cae/stack_definition.json#L124

ocofaigh commented 1 month ago

@jor2 That stack is not in the main catalog - its in Community so naming was never reviewed. Hence why I asked the guys for feedback on the naming for this stack.

@joealewine Allen is correct, the Stack supports passing an existing KMS instance, which could be HPCS. So it should say 1 - Key management instead of Key Protect (cc @jor2 ).

@SirSpidey The Activity tracking that is deployed is not the deprecated one - its the AT route to COS bucket. I think 2 - Logging, monitoring, activity tracking is fine, as even when Cloud logs comes out, it still falls under logging