Closed joealewine closed 3 months ago
/run pipeline
@joealewine Another issue I missed: directory needs to be plural: /reference architectures/
and then and references to it (e.g., from ibm_catalog.json
) need to be updated.
@joealewine After you resolve the conflict with the core-security-services-architecture.svg
file, we can probably get it merged.
/run pipeline
/run pipeline
/run pipeline
@ocofaigh can you please merge this?
The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.
The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.
@bhakta-ibm Just heard from Conall, so I think you are working on this. But the background is that the directory needs to be plural for the cloud docs jobs (reference architectures
), so the new diagram probably needs to be renamed/added to the PR.
The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.
@bhakta-ibm Just heard from Conall, so I think you are working on this. But the background is that the directory needs to be plural for the cloud docs jobs (
reference architectures
), so the new diagram probably needs to be renamed/added to the PR.
@joealewine is on it, the branch is on his fork so couldn't make the change.
@bhakta-ibm @ocofaigh Ok I think I've got it fixed now (or rather, just renamed, so the file is the same as it was in the main branch)
/run pipeline
Would you be able to add it to the .gitignore file to ensure it can't be committed in the future?
@joealewine We have these instructions for ignoring .DS_STORE files: Macs only: Ignoring .DS_Store files
I will not be adding it to gitignore. Every time I touch something in this PR something else seems to break. So I'll let one of you do that. I just want this thing merged so I can link to it from other docs. That's it
/run pipeline
I will not be adding it to gitignore. Every time I touch something in this PR something else seems to break. So I'll let one of you do that. I just want this thing merged so I can link to it from other docs. That's it
I agree, we are holding a lot of updates for next revisions. Let us push these into repo and address next set of changes in another PR.
:tada: This PR is included in version 0.2.1 :tada:
The release is available on:
v0.2.1
Your semantic-release bot :package::rocket:
Description
Add reference architecture doc to CSS DA repo.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers