terraform-ibm-modules / stack-ibm-core-security-services

Deploy core security and other supporting services to get set up to manage the security compliance of the resources in your account.
Apache License 2.0
1 stars 4 forks source link

Create reference-architecture-css.md #35

Closed joealewine closed 3 months ago

joealewine commented 3 months ago

Description

Add reference architecture doc to CSS DA repo.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

SirSpidey commented 3 months ago

/run pipeline

SirSpidey commented 3 months ago

@joealewine Another issue I missed: directory needs to be plural: /reference architectures/

and then and references to it (e.g., from ibm_catalog.json) need to be updated.

SirSpidey commented 3 months ago

@joealewine After you resolve the conflict with the core-security-services-architecture.svg file, we can probably get it merged.

SirSpidey commented 3 months ago

/run pipeline

SirSpidey commented 3 months ago

/run pipeline

SirSpidey commented 3 months ago

/run pipeline

bhakta-ibm commented 3 months ago

@ocofaigh can you please merge this?

bhakta-ibm commented 3 months ago

The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.

SirSpidey commented 3 months ago

The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.

@bhakta-ibm Just heard from Conall, so I think you are working on this. But the background is that the directory needs to be plural for the cloud docs jobs (reference architectures), so the new diagram probably needs to be renamed/added to the PR.

bhakta-ibm commented 3 months ago

The PR should just have reference to that diagram should not replace it. So not sure the diagram is commited.

@bhakta-ibm Just heard from Conall, so I think you are working on this. But the background is that the directory needs to be plural for the cloud docs jobs (reference architectures), so the new diagram probably needs to be renamed/added to the PR.

@joealewine is on it, the branch is on his fork so couldn't make the change.

joealewine commented 3 months ago

@bhakta-ibm @ocofaigh Ok I think I've got it fixed now (or rather, just renamed, so the file is the same as it was in the main branch)

daniel-butler-irl commented 3 months ago

/run pipeline

SirSpidey commented 3 months ago

Would you be able to add it to the .gitignore file to ensure it can't be committed in the future?

@joealewine We have these instructions for ignoring .DS_STORE files: Macs only: Ignoring .DS_Store files

joealewine commented 3 months ago

I will not be adding it to gitignore. Every time I touch something in this PR something else seems to break. So I'll let one of you do that. I just want this thing merged so I can link to it from other docs. That's it

daniel-butler-irl commented 3 months ago

/run pipeline

hvetsa commented 3 months ago

I will not be adding it to gitignore. Every time I touch something in this PR something else seems to break. So I'll let one of you do that. I just want this thing merged so I can link to it from other docs. That's it

I agree, we are holding a lot of updates for next revisions. Let us push these into repo and address next set of changes in another PR.

terraform-ibm-modules-ops commented 3 months ago

:tada: This PR is included in version 0.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: