fix: adding iam_engine_enabled option

iamar7 commented 2 months ago

Description

Resolves: https://github.com/terraform-ibm-modules/stack-ibm-core-security-services/issues/59

Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

I see you updated all the icons in the diagram except the event notifications one - can we be consistent and update the one too?

Can you tell me which icon to use for event notification as I see the same icon being used here in the event-notification DA reference-architecture.

ocofaigh commented 2 months ago

@iamar7 No idea - where did you get the other icons from? Maybe check with people who worked on the other DA diagrams

iamar7 commented 2 months ago

@iamar7 No idea - where did you get the other icons from? Maybe check with people who worked on the other DA diagrams

I've used the icons from ibm-cloud stencils repo here but it doesn't have any icon for event-notification.

iamar7 commented 2 months ago

@iamar7 No idea - where did you get the other icons from? Maybe check with people who worked on the other DA diagrams

I asked about the icon in the IBM Cloud Stencils channel, and they confirmed that it is not available in the current library. I have created an issue for further tracking.

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 2 months ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

Blocked by known issue with the tests which is being debugged internally

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

iamar7 commented 1 month ago

/run pipeline

terraform-ibm-modules-ops commented 1 month ago

:tada: This issue has been resolved in version 1.3.0 :tada:

The release is available on:

GitHub release
v1.3.0

Your semantic-release bot :package::rocket:

terraform-ibm-modules / stack-ibm-core-security-services