terraform-ibm-modules / stack-retrieval-augmented-generation

Apache License 2.0
1 stars 8 forks source link

fix: updated stack definition #117

Closed Ak-sky closed 1 month ago

Ak-sky commented 1 month ago

Description

Updated stack definition to have input for existing_kms_instance_crn.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Ak-sky commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

PR test failed-

    tests.go:254: [PROJECTS] Configuration 6 - Sample RAG app configuration is still deploying
    tests.go:257: 
            Error Trace:    /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.33.2/testprojects/tests.go:257
                                        /__w/stack-retrieval-augmented-generation/stack-retrieval-augmented-generation/tests/pr_test.go:38
            Error:          Received unexpected error:
                            cloudant read error: get project config
            Test:           TestProjectsFullTest
    tests.go:364: [PROJECTS] Deleting Test Project
    tests.go:366: 
            Error Trace:    /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.33.2/testprojects/tests.go:366
            Error:          Received unexpected error:
                            cloudant read error: get all configs to delete
            Test:           TestProjectsFullTest
    pr_test.go:39: 
            Error Trace:    /__w/stack-retrieval-augmented-generation/stack-retrieval-augmented-generation/tests/pr_test.go:39
            Error:          Received unexpected error:
                            cloudant read error: get project config
            Test:           TestProjectsFullTest
    pr_test.go:42: TestProjectsFullTest Failed
--- FAIL: TestProjectsFullTest (5675.81s)
FAIL
FAIL    command-line-arguments  5675.823s
FAIL
make: *** [Makefile:126: run-tests] Error 1
vburckhardt commented 1 month ago

I merged for now - but we should just update the description in a subsequent PR

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: