terraform-ibm-modules / stack-retrieval-augmented-generation

Apache License 2.0
1 stars 8 forks source link

fix: adding iam engine option to SM and prefix to SCC #137

Open iamar7 opened 1 week ago

iamar7 commented 1 week ago

Description

Resolves: https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/issues/12, https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/issues/130

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

iamar7 commented 1 week ago

/run pipeline

iamar7 commented 1 week ago

/run pipeline

iamar7 commented 1 week ago

/run pipeline

ocofaigh commented 6 days ago

@daniel-butler-irl If this stack is being updated to consume the core security services stack, then the change to add iam_engine_enabled should come in that stack first right?

iamar7 commented 6 days ago

@daniel-butler-irl If this stack is being updated to consume the core security services stack, then the change to add iam_engine_enabled should come in that stack first right?

core-security-services-stack PR ~> https://github.com/terraform-ibm-modules/stack-ibm-core-security-services/pull/70

iamar7 commented 1 day ago

/run pipeline