terraform-ibm-modules / stack-retrieval-augmented-generation

A deployable architecture that automates the deployment of a sample gen AI Pattern on IBM Cloud, including all underlying IBM Cloud and WatsonX infrastructure.
Apache License 2.0
1 stars 11 forks source link

Update wrapper version #217

Closed daniel-butler-irl closed 1 month ago

daniel-butler-irl commented 1 month ago

Description

updating wrapper and tests

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

bug in the wrapper fixed: https://github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper/pull/878

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

Bug in the wrapper causes this test to pass on failure. working on fix, do not merge

daniel-butler-irl commented 1 month ago

closing letting renovate update

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

@daniel-butler-irl If the test wrapper config is ok here, and pipeline is only failing due to backend issue, lets proceed with a force merge here. I kind of want the updater wrapper to run in https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/pull/208

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

/run pipeline

daniel-butler-irl commented 1 month ago

@ocofaigh Not sure if you want to force merge, all deploys are successful it just failed on undeploy. Looks like its KMS still has key inside it and fails instance delete. Presumably this is an issue in the main branch too...

"Result": { │ "details": "{\"status_code\":409,\"name\":\"ConflictError\",\"message\":{\"message\":\"CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys\",\"name\":\"ConflictError\",\"status_code\":409,\"transaction_id\":\"\"},\"description\":\"CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys\"}", │ "error_code": "RC-ServiceBrokerErrorResponse", │ "message": "Please contact the Service Provider for this error. [409, Conflict] CONTAINS_ACTIVE_KEYS: Remove all keys before de-provisioning: Instance contains 2 active keys", │ "status_code": 422, │ "transaction_id": "626c-8f564977efde97e1" │ },

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: