terraform-ibm-modules / terraform-ibm-account-infrastructure-base

A general base layer module for setting up a newly provisioned account.
Apache License 2.0
0 stars 2 forks source link

feat: Add cloud logs in DA #250

Closed arya-girish-k closed 14 hours ago

arya-girish-k commented 5 days ago

Description

This PR integrates cloud logs into DA Git Issue

Release required?

Release notes content

Add cloud logs as one of the target service in DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

arya-girish-k commented 5 days ago

/run pipeline

Ak-sky commented 5 days ago

@ocofaigh, this PR also has space in the commit message, I have discussed the same with @arya-girish-k.

ocofaigh commented 5 days ago

@Ak-sky Its the mergers responsibility to fix the commit message used on merge (as per https://terraform-ibm-modules.github.io/documentation/#/merging). The contributor can actually use any commit message they want as long as they fill in the details in the PR template

arya-girish-k commented 4 days ago

/run pipeline

arya-girish-k commented 23 hours ago

/run pipeline

arya-girish-k commented 20 hours ago

@ocofaigh :Could you please review this?

terraform-ibm-modules-ops commented 14 hours ago

:tada: This PR is included in version 1.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: