terraform-ibm-modules / terraform-ibm-base-ocp-vpc

Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
2 stars 7 forks source link

feat: update description for ingress hostname #419

Closed Khuzaima05 closed 6 months ago

Khuzaima05 commented 6 months ago

Description

updated the description for ingress hostname

issue: https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/issues/416

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Khuzaima05 commented 6 months ago

/run pipeline

Khuzaima05 commented 6 months ago

/run pipeline

akocbek commented 6 months ago

Do we have issue created for ?

There is a separate ticket to change the output name https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5276 in provider. I think the module should change the name after the provider does to avoid confusion.

if not then I recommend to create it

Khuzaima05 commented 6 months ago

/run pipeline

terraform-ibm-modules-ops commented 6 months ago

:tada: This PR is included in version 3.20.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: