terraform-ibm-modules / terraform-ibm-base-ocp-vpc

Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
2 stars 7 forks source link

fix: upgrade cos module to latest #434

Closed toddgiguere closed 5 months ago

toddgiguere commented 5 months ago

Description

Upgrade terraform-ibm-cos module to the latest version of v8.2.6.

Minor change needed for this upgrade, removed parameter create_resource_key for the COS module as that input has been removed. Did not need to be replaced as it was set to false.

Release required?

Release notes content

Upgraded terraform-ibm-cos module to the latest version of v8.2.6.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

toddgiguere commented 5 months ago

/run pipeline

toddgiguere commented 5 months ago

Upgrade test caught the two following resources to be destroyed, which is expected and was part of the change in terraform-ibm-cos module from v7 to v8:

module.ocp_base.module.cos_instance[0].terraform_data.generate_hmac_credentials
module.ocp_base.module.cos_instance[0].terraform_data.resource_key_existing_serviceid_crn

These were only lifecycle hooks (terraform_data) and were expected to be removed from state file after upgrade.

Will skip upgrade test.

toddgiguere commented 5 months ago

/run pipeline

terraform-ibm-modules-ops commented 5 months ago

:tada: This PR is included in version 3.23.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: