feat: add `wait_for_apply` option in `kms_config` object input variable

ocofaigh commented 5 months ago

Description

Undocumented feature which should address https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/issues/747

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

ocofaigh commented 5 months ago

/run pipeline

ocofaigh commented 5 months ago

/run pipeline

ocofaigh commented 5 months ago

The pipeline timed out after 3 hours so we may want to reconsider defaulting wait_for_apply to true if its going to take that long. I have extended the timeout to 5 hours to see if we can figure out exactly how long it will take though before we decide.

ocofaigh commented 5 months ago

The timeout seen in previous error seems unrelated. The re-run took 41mins: module.ocp_base.ibm_container_vpc_cluster.autoscaling_cluster[0]: Creation complete after 41m27s [id=cp85nr9z06uja9vrao20]

ocofaigh commented 5 months ago

/run pipeline

terraform-ibm-modules-ops commented 5 months ago

:tada: This PR is included in version 3.24.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

terraform-ibm-modules / terraform-ibm-base-ocp-vpc