Closed Aashiq-J closed 2 months ago
/run pipeline
/run pipeline
/run pipeline
/run pipeline
tested in a private vsi with no outbound access
/run pipeline
/run pipeline
/run pipeline
/run pipeline
/run pipeline
/run pipeline
/run pipeline
/run pipeline
/run pipeline
@ocofaigh , @vbontempi
/run pipeline
/run pipeline
/run pipeline
in my opinion the fetch_data function may be designed in a different way to avoid to return a list of apikeys to be filtered later: maybe it could still retrieve the list of apikeys but it could simply compare each one with APIKEY_KEY_NAME (got as input param) and then it could simply return a different return code if the apikeys must be reset or not. Moreover this would avoid also the dependency on jq.
This is just an opinion By looking at the current code I haven't see something to fix, probably the RIAS version currently hardcoded could be calculated.
Considering this comment, the script looks ok now
/run pipeline
:tada: This PR is included in version 3.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Description
Issue: https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/issues/438
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers