test: update the confirm lb script to support private agents

[Aashiq-J]

Description

Issue: https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/issues/438

Release required?

• [ ] No release
• [ ] Patch release (x.x.X)
• [x] Minor release (x.X.x)
• [ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• [ ] If relevant, a test for the change is included or updated with this PR.
• [ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

tested in a private vsi with no outbound access

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

@ocofaigh , @vbontempi

• Removed the need of ibmcloud_api_key in the root module. Using token to fetch all the keys and run the reset logic.
• Found the private endpoint to reset the api key
• removed the dependency on API_VERSION date.

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[vbontempi]

in my opinion the fetch_data function may be designed in a different way to avoid to return a list of apikeys to be filtered later: maybe it could still retrieve the list of apikeys but it could simply compare each one with APIKEY_KEY_NAME (got as input param) and then it could simply return a different return code if the apikeys must be reset or not. Moreover this would avoid also the dependency on jq.

This is just an opinion By looking at the current code I haven't see something to fix, probably the RIAS version currently hardcoded could be calculated.

Considering this comment, the script looks ok now

[Aashiq-J]

/run pipeline

[terraform-ibm-modules-ops]

:tada: This PR is included in version 3.26.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: