terraform-ibm-modules / terraform-ibm-base-ocp-vpc

Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
1 stars 6 forks source link

fix: fix the value passed to provider for `disable_outbound_traffic_protection` to consider use case when data lookup checks current default version #455

Closed ocofaigh closed 2 months ago

ocofaigh commented 2 months ago

Description

The format of the data lookup returns like this: "4.14.24" (includes patch version). So need to update logic to use startswith() so the use case of user passing 'default' or null for version will work

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 2 months ago

/run pipeline

terraform-ibm-modules-ops commented 2 months ago

:tada: This PR is included in version 3.25.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: