Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
1
stars
6
forks
source link
fix: fix the value passed to provider for `disable_outbound_traffic_protection` to consider use case when data lookup checks current default version #455
The format of the data lookup returns like this: "4.14.24" (includes patch version). So need to update logic to use startswith() so the use case of user passing 'default' or null for version will work
Release required?
[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)
Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline
Checklist for reviewers
[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.
For mergers
Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Description
The format of the data lookup returns like this:
"4.14.24"
(includes patch version). So need to update logic to usestartswith()
so the use case of user passing 'default' ornull
for version will workRelease required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers