terraform-ibm-modules / terraform-ibm-base-ocp-vpc

Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
1 stars 5 forks source link

Changing operating_system on existing cluster does not trigger a destroy and create #462

Open vburckhardt opened 1 month ago

vburckhardt commented 1 month ago

This may need to be surfaced to provider

ocofaigh commented 1 month ago

@vburckhardt provider says This field only affects cluster creation:

operating_system - (Optional, String) The operating system of the workers in the default worker pool. For supported options, see Red Hat OpenShift on IBM Cloud version information or IBM Cloud Kubernetes Service version information. This field only affects cluster creation, to manage the default worker pool, create a dedicated worker pool resource.

So probably working as expected. Maybe we create enhancement request?

vburckhardt commented 3 weeks ago

@ocofaigh - I think a bug should be filed, as it's not consistent with the terraform common practices - it should attempt to destroy and recreate. It is up to the user of the provider to decide on the behavior, rather than the provider itself. https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#ignore_changes change field exists for this reason.

ocofaigh commented 2 weeks ago

Created provider issue: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5501

ocofaigh commented 2 weeks ago

@vburckhardt Provider team replied: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5501#issuecomment-2225033813