terraform-ibm-modules / terraform-ibm-base-ocp-vpc

Provisions a Red Hat OpenShift VPC cluster on IBM Cloud
Apache License 2.0
2 stars 7 forks source link

fix: added validation blocks and updated operating system for worker pools. #466

Closed imprateeksh closed 3 months ago

imprateeksh commented 3 months ago

Description

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

vburckhardt commented 3 months ago

As part of this PR, we should also have at least one of the example using RHCOS to ensure testing coverage for that OS

imprateeksh commented 3 months ago

As part of this PR, we should also have at least one of the example using RHCOS to ensure testing coverage for that OS

Sure @vburckhardt

imprateeksh commented 3 months ago

Added the default pool as RHCOS in multizone region example. Both RHEL 8 and RHCOS operating systems can be seen in two worker pools

image
imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

Locally executed themultiple-mzr-cluster test. Here is the results output_test_1.txt This test has however failed but due to a different reason shown below, will again attempt to run the test. image

Also, Failure is seen in PR tests as -

image

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

Local Test passed when added disable_outbound_traffic_protection = true in the clusters. Here is the execution result. output_test_2.txt

image
imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

PR is failing with schematics test timing out. Another PR is currently in progress to address this. I have also added the same changes in this PR to ensure tests are passing.

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

Two changes are in progress -

  1. operating_system can be at two places in the code and validation is considered only at one place i.e. outside for default os but for worker pools map, now it is in progress.
  2. Another validation to be added for this condition - image
vburckhardt commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

Scenarios, that I have verified in local are -

Sno Scenario Expected output Actual output
1 If os is RHCOS then ocp version has to be >=4.15 No Error should be seen Pass
2 If os is rhcos and ocp_version = 4.14 Error should be shown Plan failed
3 If the default os is RHEL, worker pools' os also has to be RHEL No Error should be seen Pass
4 If the default os is RHEL and worker pools' os is RHCOS Error should be shown Fails, error is seen
I 5 If the default os is RHCOS and worker pools os is RHCOS No error should be shown Passed, no error is seen
6 If the default os is RHCOS and worker pools os is RHEL No error should be shown Passed, no error is seen

Some screenshots from the scenarios:

If the default os is RHEL, worker pools' os are also RHEL

image

If default os is RHCOS, worker pool os is RHEL

image image

If default os is RHEL, worker pool os is RHCOS and also ocp_version provided is 4.14 ,

Error expected is seen:

image image

Scenario 2 : If default os is RHCOS, worker pool os is RHEL and ocp_version provided is 4.14

Again error is expected and received as:

image image

If default os is RHEL, worker pool os is RHCOS and ocp_version provided >= 4.15 ,

image image
imprateeksh commented 3 months ago

/run pipeline

imprateeksh commented 3 months ago

/run pipeline

terraform-ibm-modules-ops commented 3 months ago

:tada: This issue has been resolved in version 3.28.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: