search

terraform-ibm-modules / terraform-ibm-cbr

This module can be used to provision and configure Context Based Restrictions.
Apache License 2.0
0 stars 2 forks source link

Support Terraform 1.8 #455

Closed unblu-inc closed 3 months ago

unblu-inc commented 3 months ago

Description

You restrict the Terraform version to ">= 1.3.0, <1.7.0" in version.tf. Is there a good reason for it? If not, can you allow 1.8?

unblu-inc commented 3 months ago

BTW: 1.7 is also not allowed:

╷
│ Error: Unsupported Terraform Core version
│ 
│   on .terraform/modules/cbr_fscloud/modules/cbr-rule-module/version.tf line 2, in terraform:
│    2:   required_version = ">= 1.3.0, <1.7.0"
│ 
│ Module module.cbr_fscloud.module.cbr_rule (from ../../modules/cbr-rule-module) does not support Terraform version 1.7.5. To proceed, either choose another
│ supported Terraform version or update this version constraint. Version constraints are normally set for good reason, so updating the constraint may lead
│ to other errors or unexpected behavior.
╵
ocofaigh commented 3 months ago

@unblu-inc We had it restricted to only allow versions that IBM Cloud Schematics supported. However we are more than likely going to be removing the upper limit here across all of our modules so please bare with us while we make a final decision and start rolling that out

gysel commented 3 months ago

Excellent, thanks! (I created the this issue but had the wrong account active when I did so ;) )

ocofaigh commented 3 months ago

@gysel Upper range constraints have been removed in https://github.com/terraform-ibm-modules/terraform-ibm-cbr/releases/tag/v1.22.2